Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: announcement banner on deposit withdraw screens #297

Merged
merged 17 commits into from
Jan 2, 2025
Merged

feat: announcement banner on deposit withdraw screens #297

merged 17 commits into from
Jan 2, 2025

Conversation

kylehoang92
Copy link
Collaborator

No description provided.

@kylehoang92 kylehoang92 force-pushed the feat/announcement-banner-on-deposit-withdraw-screens branch 5 times, most recently from 3c89724 to 3b5f7b9 Compare December 18, 2024 07:16
@kylehoang92 kylehoang92 force-pushed the feat/announcement-banner-on-deposit-withdraw-screens branch from 3b5f7b9 to 184f8df Compare December 18, 2024 08:17
@kylehoang92 kylehoang92 changed the title Feat/announcement banner on deposit withdraw screens feat: announcement banner on deposit withdraw screens Dec 18, 2024
sarah-thong
sarah-thong reviewed Dec 20, 2024
View reviewed changes
config.schema.json Outdated Show resolved Hide resolved
.github/markets/pr_template.md Outdated Show resolved Hide resolved
.github/markets/pr_template.md Outdated Show resolved Hide resolved
.github/markets/pr_template.md Outdated Show resolved Hide resolved
config.schema.json Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
@sarah-thong
Copy link
Collaborator

Other Comments

  • Don't we already have another field transfer_disabled_tokens to temporarily disable token transfers. Pls choose 1 and remove the other 1 for this PR.

@kylehoang92 kylehoang92 force-pushed the feat/announcement-banner-on-deposit-withdraw-screens branch from 1d56a68 to 8a0fd9f Compare December 26, 2024 09:08
sarah-thong
sarah-thong reviewed Dec 27, 2024
View reviewed changes
.github/markets/pr_template.md Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
@sarah-thong
Copy link
Collaborator

sarah-thong commented Dec 27, 2024 •
edited
Loading

Other Comments

  • Pls sync your PR to the latest master
  • As mentioned, there's another field transfer_disabled_tokens that has pretty much the same functionality. If it is not longer used, pls remove in this PR.
    image

sarah-thong
sarah-thong reviewed Dec 30, 2024
View reviewed changes
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
sarah-thong
sarah-thong reviewed Dec 31, 2024
View reviewed changes
scripts/check_configs.ts Outdated Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
sarah-thong
sarah-thong reviewed Dec 31, 2024
View reviewed changes
.github/markets/pr_template.md Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
@sarah-thong sarah-thong merged commit 94ce39d into master Jan 2, 2025
1 check passed
@sarah-thong sarah-thong deleted the feat/announcement-banner-on-deposit-withdraw-screens branch January 2, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-thong sarah-thong sarah-thong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylehoang92 @sarah-thong